fix: autocapture crash when encountering non-Element DOM nodes #2400
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PostHog/posthog#38691
Changes
Added validation to skip non-Element DOM nodes in
autocapturePropertiesForElement
. The code was trying to access.tagName
on nodes that don't have this property (text nodes, comment nodes, etc), causing crashesTwo checks added:
parentNode
is an Element before adding it to the listisElementNode()
helperAlso fixed a type mismatch where
getAttribute('href')
returnsstring | null
but the code expectedstring | false
, causing a TypeScript errorRelease info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changeset
to generate a changeset file