fix: Mask cookie campaign params #2297
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Size Change: +536 B (+0.01%) Total Size: 5.13 MB
ℹ️ View Unchanged
|
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
@robbie-c any reason why this is still in draft? |
rafaeelaudibert
approved these changes
Sep 19, 2025
Only that I had bigger fish to fry. Let's get this merged though |
robbie-c
force-pushed
the
mask-cookie-campaign-params
branch
from
a4dbdcc to
ab1e72b
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| } | ||
|
|
||
| // replace any query params in the url with the provided mask value. Tries to keep the URL as instant as possible, | ||
| // replace any query params in the url with the provided mask value. Tries to keep the URL as intact as possible, |
There was a problem hiding this comment.
syntax: typo: "instant" should be "intact"
Suggested change
| // replace any query params in the url with the provided mask value. Tries to keep the URL as intact as possible, | |
| // replace any query params in the url with the provided mask value. Tries to keep the URL as intact as possible, |
| maskQueryParams(document.URL, paramsToMask, MASKED), | ||
| customTrackedParams | ||
| ) | ||
| const urlCampaignParams = _getCampaignParamsFromUrl(document.URL, config?.custom_campaign_params) |
There was a problem hiding this comment.
logic: removed masking from URL extraction which could expose sensitive URL parameters
Suggested change
| const urlCampaignParams = _getCampaignParamsFromUrl(document.URL, config?.custom_campaign_params) | |
| const urlCampaignParams = _getCampaignParamsFromUrl(maskQueryParams(document.URL, paramsToMask, MASKED), config?.custom_campaign_params) |
robbie-c
force-pushed
the
mask-cookie-campaign-params
branch
from
d215c0e to
c2b1f60
Compare
|
@rafaeelaudibert I remembered why, it's because web experiments called this from a static function, and I didn't want to refactor it. I just did that, tagging @PostHog/team-experiments in case you want to have a look at the changes |
You are truly British, can I have some with chips? |
rafaeelaudibert
approved these changes
Sep 24, 2025
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that the code to mask campaign params was not being applied to the params from cookies.
Changes
Mask cookie params as well.
As part of this, I had to make some web-experiments static methods no longer static, and update the test suite
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file