Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix changelog after automation error #1623

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

pauldambra
Copy link
Member

CD task was broken because of linting which meant we never published 1.202.3 and 1.202.4 is mungled up with 1.202.5

this updates the changelog to represent what is in each release

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 19, 2024 3:21pm

@pauldambra pauldambra requested a review from a team December 19, 2024 15:09
Copy link
Member

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was 1.202.4 published? If not, we could simply put all of this inside 1.202.3 instead

It's terrible that npm allowed us to publish 1.202.4 without publishing 1.202.3

Copy link

Size Change: 0 B

Total Size: 3.22 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/array.full.es5.js 262 kB
dist/array.full.js 365 kB
dist/array.full.no-external.js 364 kB
dist/array.js 179 kB
dist/array.no-external.js 178 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/main.js 180 kB
dist/module.full.js 365 kB
dist/module.full.no-external.js 364 kB
dist/module.js 179 kB
dist/module.no-external.js 178 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra
Copy link
Member Author

Was 1.202.4 published? If not, we could simply put all of this inside 1.202.3 instead

yep, 1.202.3 was never published, 1.202.4 was published but the automation that updates the changelog can't cope with anything but a clean set of releases (it doesn't even cope with two merges too close together 🙈)

It's terrible that npm allowed us to publish 1.202.4 without publishing 1.202.3

they only enforce that you don't try and publish a duplicate iiuc

@pauldambra pauldambra merged commit c2624b5 into main Dec 19, 2024
14 checks passed
@pauldambra pauldambra deleted the chore/fix-changelog-after-automation-error branch December 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants