Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change default transport to fetch #1612

Merged
merged 3 commits into from
Dec 17, 2024
Merged

fix: Change default transport to fetch #1612

merged 3 commits into from
Dec 17, 2024

Conversation

benjackwhite
Copy link
Collaborator

Changes

...

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite added the bump minor Bump minor version when this PR gets merged label Dec 17, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 17, 2024 9:46am

@posthog-bot
Copy link
Collaborator

Hey @benjackwhite! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Size Change: +80 B (0%)

Total Size: 3.22 MB

Filename Size Change
dist/array.full.es5.js 262 kB +8 B (0%)
dist/array.full.js 365 kB +8 B (0%)
dist/array.full.no-external.js 364 kB +8 B (0%)
dist/array.js 179 kB +8 B (0%)
dist/array.no-external.js 177 kB +8 B (0%)
dist/main.js 180 kB +8 B (0%)
dist/module.full.js 365 kB +8 B (0%)
dist/module.full.no-external.js 364 kB +8 B (0%)
dist/module.js 179 kB +8 B (0%)
dist/module.no-external.js 178 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

pauldambra
pauldambra approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm in 🚀

@benjackwhite benjackwhite merged commit 2ccc06c into main Dec 17, 2024
13 checks passed
@benjackwhite benjackwhite deleted the feat/default-to-fetch branch December 17, 2024 10:23
pauldambra
pauldambra reviewed Dec 17, 2024
View reviewed changes
src/posthog-featureflags.ts
@@ -433,7 +433,7 @@ export class PostHogFeatureFlags {

if (!existing_early_access_features || force_reload) {
this.instance._send_request({
transport: 'XHR',
transport: 'fetch',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this just not specify their own transport and use the default instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang post merge comment... never mind :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1614

@pauldambra pauldambra mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

@thmsobrmlr thmsobrmlr Awaiting requested review from thmsobrmlr

Assignees
No one assigned
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjackwhite @posthog-bot @pauldambra