Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't crash on bigints #1573

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Nov 29, 2024

Changes

Fixes #1440

I'm a bit wary that there's another root cause we're missing, I would like to hear from those users where the BigInts came from in the first place, but in the mean-time let's not crash

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Nov 29, 2024 6:07pm

Copy link

Size Change: +279 B (+0.01%)

Total Size: 3.18 MB

Filename Size Change
dist/array.full.es5.js 258 kB +54 B (+0.02%)
dist/array.full.js 361 kB +25 B (+0.01%)
dist/array.full.no-external.js 360 kB +25 B (+0.01%)
dist/array.js 175 kB +25 B (+0.01%)
dist/array.no-external.js 174 kB +25 B (+0.01%)
dist/main.js 176 kB +25 B (+0.01%)
dist/module.full.js 361 kB +25 B (+0.01%)
dist/module.full.no-external.js 360 kB +25 B (+0.01%)
dist/module.js 175 kB +25 B (+0.01%)
dist/module.no-external.js 174 kB +25 B (+0.01%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.5 kB
dist/dead-clicks-autocapture.js 14.3 kB
dist/exception-autocapture.js 9.37 kB
dist/external-scripts-loader.js 2.29 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.2 kB
dist/tracing-headers.js 1.75 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one less crash in the world 🚢

@robbie-c robbie-c added the bump patch Bump patch version when this PR gets merged label Nov 30, 2024
@robbie-c robbie-c merged commit fce2141 into main Nov 30, 2024
20 checks passed
@robbie-c robbie-c deleted the feature/handle-serialization-of-bigints branch November 30, 2024 09:34
@dandyling
Copy link

@robbie-c We are using protobufs i64, and that is converted to bigint in the front-end

@robbie-c
Copy link
Member Author

@dandyling were you experiencing this crash before, and does this fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigInt serialization error in encodePostData
3 participants