Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): 7-point likert scale didn't work with branching logic #1424

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

dmarticus
Copy link
Contributor

@dmarticus dmarticus commented Sep 18, 2024

Changes

A user reported that our 7-point likert scales didn't support branching logic in the PostHog UI, which is good, because posthog-js didn't support them either and would've thrown a runtime error if users tried it.

This change supports handling 7-point scales for our branching logic. Will ship with the PostHog UI changes, but this change should go in first so that we don't have users hitting runtime errors.

Demo of it all working: https://www.loom.com/share/e22de74e2bea4b7cb66fe34343e68916

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Sep 18, 2024 5:28pm

Copy link

github-actions bot commented Sep 18, 2024

Size Change: +512 B (+0.04%)

Total Size: 1.21 MB

Filename Size Change
dist/array.full.js 347 kB +128 B (+0.04%)
dist/array.js 163 kB +128 B (+0.08%)
dist/main.js 164 kB +128 B (+0.08%)
dist/module.js 163 kB +128 B (+0.08%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 111 kB
dist/recorder.js 111 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@dmarticus dmarticus added the bump minor Bump minor version when this PR gets merged label Sep 19, 2024
@dmarticus dmarticus merged commit aec7d81 into main Sep 19, 2024
18 checks passed
@dmarticus dmarticus deleted the fix/7-point-likert-scale-next-question branch September 19, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants