-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bundle option without any external scripts #1413
Open
benjackwhite
wants to merge
31
commits into
main
Choose a base branch
from
feat/no-external-scripts-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+485
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +2.71 kB (+0.1%) Total Size: 2.79 MB
ℹ️ View Unchanged
|
oh, well now I need to test the external scripts typing PR... that's not fair 🤣 |
Any updates? Thanks you |
…ipts-option # Conflicts: # src/utils/globals.ts
11 tasks
…ipts-option # Conflicts: # src/utils/globals.ts
An error occurred while trying to automatically change base from
feat/type-safe-ph-extensions
to
main
September 20, 2024 10:23
benjackwhite
added
release alpha
NB _when applied_ release an alpha version to NPM
bump minor
Bump minor version when this PR gets merged
labels
Sep 20, 2024
# Conflicts: # src/utils/globals.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
Bump minor version when this PR gets merged
release alpha
NB _when applied_ release an alpha version to NPM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Builds on top of @pauldambra 's great external scripts typing work and makes the external deps loader a separate extension that we can then include depending on the bundle
This allows someone to import specific modules such as
Checklist
…ut it