Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Array.from override #1322

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix: Array.from override #1322

merged 1 commit into from
Jul 29, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jul 26, 2024

Changes

Some frameworks override the second argument of Array.from. A customer reported an issue where their stylesheets were not correctly parsed because of this. Changing to use Array.from with one argument followed by .map with the applied function

This has been fixed in the alpha-14 release of rrweb: rrweb-io/rrweb#1464. We're currently on alpha-13 and are blocked on upgrading to alpha-16 because of some typing issues.
We could upgrade to alpha-14 but the effort of reapplying all our old patches probably isn't worth it. It's much easier to just add this one

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@daibhin daibhin added the bump patch Bump patch version when this PR gets merged label Jul 26, 2024
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jul 26, 2024 3:28pm

Copy link

Size Change: +15 B (0%)

Total Size: 1.16 MB

Filename Size Change
dist/array.full.js 331 kB +5 B (0%)
dist/recorder-v2.js 110 kB +5 B (0%)
dist/recorder.js 110 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.js 152 kB
dist/exception-autocapture.js 10.4 kB
dist/main.js 153 kB
dist/module.js 152 kB
dist/surveys-preview.js 59.7 kB
dist/surveys.js 64.9 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@daibhin daibhin requested a review from a team July 26, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants