Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open port 8596 on temporal workers for prom metrics #766

Merged
merged 1 commit into from
Aug 7, 2023
Merged

open port 8596 on temporal workers for prom metrics #766

merged 1 commit into from
Aug 7, 2023

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Aug 7, 2023

Description

Sibling PR to PostHog/posthog#16803, to allow scraping internal metrics of the temporal workers.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@xvello xvello requested a review from a team August 7, 2023 15:09
@xvello xvello merged commit 463a76d into main Aug 7, 2023
47 checks passed
@xvello xvello deleted the xvello/temporal-prom branch August 7, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasfarias tomasfarias tomasfarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvello @tomasfarias