Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e - Microsoft Azure (install) #204

Closed
wants to merge 2 commits into from
Closed

e2e - Microsoft Azure (install) #204

wants to merge 2 commits into from

Conversation

guidoiaquinti
Copy link
Contributor

Description

Similar to #196 and #200 and #201, this PR brings an e2e test to deploy PostHog via Helm on Microsoft Azure (as requested in #183). It includes certificate signing using Let's Encrypt (see here for the certificate transparency log entries).

This is currently a WIP due to few issues I still didn't find a fix for:

  1. the federated credentials config in Microsoft Active Directory doesn't let me configure to run actions from any branch in this repository (repo:PostHog/charts-clickhouse:ref:refs/heads/* doesn't seems to work, I've asked here)
  2. the azure/login action doesn't seems to expose a way to increase the token session duration (I've opened an issue here)

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

CI should be passing.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@marcushyett-ph
Copy link
Contributor

Anything I can do to unblock this one?

@tiina303
Copy link
Contributor

tiina303 commented Dec 6, 2021

Note that we discussed this and might move Azure support to Beta to have smaller support plane as a whole. In this case we should remove the test to not be inclined to spend time on fixing them.

@fuziontech fuziontech added helm Helm chart work P3 labels Jan 18, 2022
@hazzadous
Copy link
Contributor

I going to close this to reduce the noise in this repo, if it's really important feel free to open again.

@hazzadous hazzadous closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm Helm chart work P3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants