Skip to content

forward_headers #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

forward_headers #278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad135f3
fix: forwardHeaders logic
csgulati09 Jan 8, 2025
9ac3be0
Merge branch 'main' into fix/forwardHeaders
csgulati09 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion portkey_ai/api_resources/apis/create_headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ def __init__(self, **kwargs) -> None: # type: ignore

def json(self) -> Mapping:
headers = {}
forward_headers = self.kwargs.get("forward_headers", [])
# Logic to accept both _ and - in forward_headers for devex
if forward_headers:
forward_headers = [
"-".join(header.split("_")) for header in forward_headers
]
for k, v in self.kwargs.items():
# logic for boolean type headers
if isinstance(v, bool):
Expand All @@ -22,7 +28,10 @@ def json(self) -> Mapping:
v = json.dumps(v)
if v:
if k.lower() != "authorization":
headers[get_portkey_header(k)] = str(v)
if forward_headers and k in forward_headers:
headers[k] = str(v)
else:
headers[get_portkey_header(k)] = str(v)
else:
# Logic to add Bearer only if it is not present.
# Else it would be added everytime a request is made
Expand Down
Loading