fix: cache age type fix #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Exposed the type RetrySettings as the attribute of portkey 2. Updated the cache-age check in the providerOptions part as it is inheriting it from constructs. 3. Updated the readme docs with new changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This pull request addresses several issues related to types and type checks in the codebase. It includes the following key changes:
Changes
Exposed the
RetrySettingstype as an attribute ofportkey. This allows for easier access and usage ofRetrySettingswithin theportkeymodule.Updated the cache-age check in the
providerOptionssection. This change ensures that theproviderOptionscorrectly inherit cache-age settings from constructs, improving consistency and reliability.Updated the README documentation to reflect the recent changes and additions made in the codebase. This includes incorporating the latest information from the changelog.
Related Issues
Checklist
Please review the following checklist before merging this pull request:
Additional Notes
Add any additional notes or context that may be relevant to this pull request.