-
Notifications
You must be signed in to change notification settings - Fork 740
feat: add tls options support #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arturfromtabnine
wants to merge
2
commits into
Portkey-AI:main
Choose a base branch
from
arturfromtabnine:ar/support-tls-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { Agent } from 'undici'; | ||
|
||
/** | ||
* Creates a custom HTTPS agent with SSL configuration options | ||
* | ||
* @param options - Configuration options for the HTTPS agent | ||
* @param options.rejectUnauthorized - Whether to reject unauthorized certificates (default: true) | ||
* @param options.ca - Custom CA certificate (optional) | ||
* @returns HTTPS Agent instance | ||
*/ | ||
export function getCustomHttpsAgent( | ||
options: { | ||
rejectUnauthorized?: boolean; | ||
ca?: string | Buffer; | ||
} = {} | ||
): Agent { | ||
const { rejectUnauthorized = true, ca } = options || {}; | ||
|
||
return new Agent({ | ||
connect: { | ||
rejectUnauthorized, | ||
...(ca && { ca }), | ||
}, | ||
}); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
import { Agent } from 'undici'; | ||
import { getCustomHttpsAgent } from '../../../../src/utils/fetch'; | ||
|
||
const mockCa = | ||
'-----BEGIN CERTIFICATE-----\nMOCK_CA_CERT\n-----END CERTIFICATE-----'; | ||
|
||
function getSymbolValue<T extends object>( | ||
obj: T, | ||
description: string | ||
): unknown { | ||
const symbol = Object.getOwnPropertySymbols(obj).find( | ||
(s) => s.description === description | ||
); | ||
return symbol ? (obj as any)[symbol] : undefined; | ||
} | ||
|
||
describe('getCustomHttpsAgent', () => { | ||
describe('default behavior', () => { | ||
it('should create an Agent with rejectUnauthorized true by default', () => { | ||
const agent = getCustomHttpsAgent(); | ||
const optionsValue = getSymbolValue(agent, 'options'); | ||
|
||
expect(agent).toBeInstanceOf(Agent); | ||
expect(optionsValue).toEqual({ | ||
connect: { rejectUnauthorized: true }, | ||
}); | ||
}); | ||
}); | ||
|
||
describe('with custom options', () => { | ||
it('should create an Agent with custom rejectUnauthorized option', () => { | ||
const agent = getCustomHttpsAgent({ rejectUnauthorized: false }); | ||
const optionsValue = getSymbolValue(agent, 'options'); | ||
|
||
expect(agent).toBeInstanceOf(Agent); | ||
expect(optionsValue).toEqual({ | ||
connect: { rejectUnauthorized: false }, | ||
}); | ||
}); | ||
|
||
it('should create an Agent with custom CA certificate', () => { | ||
const agent = getCustomHttpsAgent({ ca: mockCa }); | ||
const optionsValue = getSymbolValue(agent, 'options'); | ||
|
||
expect(agent).toBeInstanceOf(Agent); | ||
expect(optionsValue).toEqual({ | ||
connect: { ca: mockCa, rejectUnauthorized: true }, | ||
}); | ||
}); | ||
}); | ||
|
||
describe('with Buffer inputs', () => { | ||
it('should create an Agent with Buffer CA certificate', () => { | ||
const mockCaBuffer = Buffer.from(mockCa); | ||
const agent = getCustomHttpsAgent({ ca: mockCaBuffer }); | ||
const optionsValue = getSymbolValue(agent, 'options'); | ||
|
||
expect(agent).toBeInstanceOf(Agent); | ||
expect(optionsValue).toEqual({ | ||
connect: { ca: mockCaBuffer, rejectUnauthorized: true }, | ||
}); | ||
}); | ||
}); | ||
|
||
describe('edge cases', () => { | ||
it('should accept optional options parameter', () => { | ||
// Test that the function can be called without parameters | ||
const agent1 = getCustomHttpsAgent(); | ||
expect(agent1).toBeInstanceOf(Agent); | ||
|
||
// Test that the function can be called with empty options | ||
const agent2 = getCustomHttpsAgent({}); | ||
expect(agent2).toBeInstanceOf(Agent); | ||
|
||
// Test that the function can be called with partial options | ||
const agent3 = getCustomHttpsAgent({ rejectUnauthorized: false }); | ||
expect(agent3).toBeInstanceOf(Agent); | ||
|
||
// Test that the function can be called with null options | ||
const agent4 = getCustomHttpsAgent(null as any); | ||
expect(agent4).toBeInstanceOf(Agent); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.