Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: highlight easy param miner requests #76

Conversation

GangGreenTemperTatum
Copy link
Contributor

@GangGreenTemperTatum GangGreenTemperTatum commented Jul 17, 2024

Bambda Contributions

idea is to use this as a bambda, following creation of a custom wordlist from generating/extracting JSON params from an OAPI spec for you to easily identify the 200's which you want to throw the wordlist at (IE extensions > paramminer > guess JSON > custom wordlist etc.)

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)
➜  bambdas-fork git:(ads/createbambdaforparamminer) ✗ java -jar BambdaChecker-1.3.jar validateonly ./Filter/Proxy/HTTP/HighlightParamMinerTargets.bambda
...
Bambda ./Filter/Proxy/HTTP/HighlightParamMinerTargets.bambda parsed correct.

@GangGreenTemperTatum
Copy link
Contributor Author

additional verification with new feat commit feat: exclude mime types

image
➜  bambdas-fork git:(ads/createbambdaforparamminer) ✗ java -jar BambdaChecker-1.3.jar validateonly 
...
Bambda ./Filter/Proxy/HTTP/HighlightParamMinerTargets.bambda parsed correct.

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission!

Please can you review these feedback points?

Filter/Proxy/HTTP/HighlightParamMinerTargets.bambda Outdated Show resolved Hide resolved
Filter/Proxy/HTTP/HighlightParamMinerTargets.bambda Outdated Show resolved Hide resolved
@GangGreenTemperTatum
Copy link
Contributor Author

Thanks for your submission!

Please can you review these feedback points?

thanks for prompting me to go further and producing cleaner code! 💯 ready to 🧻

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Many thanks for your submission 🙂

@GangGreenTemperTatum
Copy link
Contributor Author

Looks good! Many thanks for your submission 🙂

thanks! 👌 😁

@ibz-portswigger ibz-portswigger merged commit 2d01566 into PortSwigger:main Jul 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants