Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DetectCORS for CustomColumn #70

Merged
merged 2 commits into from
Apr 15, 2024
Merged

add DetectCORS for CustomColumn #70

merged 2 commits into from
Apr 15, 2024

Conversation

JaveleyQAQ
Copy link
Contributor

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

Hannah-PortSwigger
Hannah-PortSwigger requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission!
It looks good, but we've added some additional feedback points for you :)

CustomColumn/Proxy/HTTP/DetectCORS.bambda Outdated Show resolved Hide resolved
CustomColumn/Proxy/HTTP/DetectCORS.bambda Outdated Show resolved Hide resolved
Hannah-PortSwigger
Hannah-PortSwigger approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@PortSwiggerWiener
Copy link
Collaborator

Looks good 👍

@PortSwiggerWiener PortSwiggerWiener merged commit 847dbe7 into PortSwigger:main Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PortSwiggerWiener PortSwiggerWiener PortSwiggerWiener approved these changes

@Hannah-PortSwigger Hannah-PortSwigger Hannah-PortSwigger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaveleyQAQ @PortSwiggerWiener @Hannah-PortSwigger