-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create DetectServerNames.bambda #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered looking for the Server header first and then looking within a set for the corresponding entry?
Analysis: Performance: V2 ( new update ) is inherently faster due to its use of a HashSet for O(1) lookup time and its singular operation of checking the 'Server' header. It doesn't require iterating through the entire response body or performing multiple regex matches, which can be expensive operations. Use Case Optimization: V1( old ) is optimized for scenarios requiring text analysis and pattern matching within the body of a response, making it suitable for its intended use case but less efficient. V2 is optimized for header analysis, which is a much simpler and faster operation due to the structured nature of HTTP headers and the efficiency of hash-based lookups.
Almost done Analysis: Use Case Optimization: V1( old ) is optimized for scenarios requiring text analysis and pattern matching within the body of a response, making it suitable for its intended use case but less efficient. V2 is optimized for header analysis, which is a much simpler and faster operation due to the structured nature of HTTP headers and the efficiency of hash-based lookups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I've added a couple of comments.
v3 updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. It's getting there :)
Thank you @PortSwiggerWiener , @Hannah-PortSwigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Bambda Contributions
@author
annotation and suitable description