configure/make: export PaWasapi_* and PaWasapiWinrt_* symbols #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maintaining this list of symbols will be obsolete after #461 using CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS. |
portaudio has three different build systems (cmake, vcproj, and configure/make). Does that mean you are planning to drop the other build systems? |
|
IMO it would be a big waste of effort and cause a lot of trouble for downstream users to maintain the redundant build systems. |
There are no plans to deprecate the other build systems. |
philburk
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(i will create a separate pull request later that exports PaWinMME_* symbols and ammend the portaudio.defs)