Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter to allow excluding Popup Trigger field from specific blocks #835 #911

Merged
merged 5 commits into from
Dec 4, 2020
Merged

Add filter to allow excluding Popup Trigger field from specific blocks #835 #911

merged 5 commits into from
Dec 4, 2020

Conversation

danieliser
Copy link
Member

Description

This adds a new filter allowing site owners to correct issues in the block editor caused by adding the popup trigger field to some blocks.

Related Issue

Issue: #835

Types of changes

Adds new pum_block_editor_popup_trigger_excluded_blocks filter that accepts array of block names.

This has been tested in the following browsers

  • Chrome

Checklist:

  • My code has been tested in the latest version of WordPress.
  • My code does not have any warnings from ESLint.
  • My code does not have any warnings from StyleLint.
  • My code does not have any warnings from PHPCS.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • All new functions and classes have code documentation.

@danieliser danieliser linked an issue Dec 4, 2020 that may be closed by this pull request
Add filter to exclude blocks with isAllowedForBlockType #835
Closed
@danieliser danieliser changed the base branch from master to develop December 4, 2020 06:59
@fpcorso fpcorso self-requested a review December 4, 2020 14:08
@fpcorso
Copy link
Contributor

fpcorso commented Dec 4, 2020

@danieliser I tested the filter with the GF block from the original issue. Works great!

@fpcorso fpcorso merged commit 1ac5d35 into develop Dec 4, 2020
@fpcorso fpcorso deleted the issue/835 branch December 4, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpcorso fpcorso Awaiting requested review from fpcorso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add filter to exclude blocks with isAllowedForBlockType
2 participants
@danieliser @fpcorso