-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(local-signing-manager): add derivationPath
for account
#33
feat(local-signing-manager): add derivationPath
for account
#33
Conversation
packages/local-signing-manager/src/lib/local-signing-manager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test in the .spec file. Ideally one for each type.
packages/local-signing-manager/src/lib/local-signing-manager.ts
Outdated
Show resolved
Hide resolved
You said:
I don't see validation for this. At the very least add a doc comment on the |
Co-authored-by: polymath-eric <[email protected]>
Validation take place by the underlying polkadot packages. |
Co-authored-by: polymath-eric <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks adding this. LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The commit error is from adding the suggestion on the UI, which I forgot husky would complain about. Merging in anyway since its the only error and it will get squashed out. |
# [1.4.0](https://github.com/PolymeshAssociation/signing-managers/compare/@polymeshassociation/[email protected]...@polymeshassociation/[email protected]) (2023-02-06) ### Features * **local-signing-manager:** add `derivationPath` for account ([#33](#33)) ([af131b6](af131b6))
🎉 This PR is included in version @polymeshassociation/[email protected] 🎉 The release is available on: |
🎉 This PR is included in version @polymeshassociation/[email protected] 🎉 The release is available on: |
🎉 This PR is included in version @polymeshassociation/[email protected] 🎉 The release is available on: |
🎉 This PR is included in version @polymeshassociation/[email protected] 🎉 The release is available on: |
🎉 This PR is included in version @polymeshassociation/[email protected] 🎉 The release is available on: |
🎉 This PR is included in version @polymeshassociation/[email protected] 🎉 The release is available on: |
🎉 This PR is included in version @polymeshassociation/[email protected] 🎉 The release is available on: |
Proposed Changes:
derivationPath
,{ seed: '...', derivationPath: '//test' }
DerivationPath
.sr25519
can accept soft/hard path, whileed25519
only accept hard path.Example of hard path :
//one
or//one//one
and soft path ://once/two
.In addition, the checking for path is being done by underlining PolkadotJS keyring package.