feat: 🎸 throw error from getAuthorization

getAuth is run first so error needs to be thrown there

src/api/procedures/__tests__/joinCreator.ts

@@ -168,38 +168,13 @@ describe('joinCreator procedure', () => {
       resolver: undefined,
     });
   });
-
-  it('should throw an error if called from v7', async () => {
-    mockContext = dsMockUtils.getContextInstance({ isV6: false });
-
-    const proc = procedureMockUtils.getInstance<Params, void>(mockContext);
-
-    const expectedError = new PolymeshError({
-      code: ErrorCode.ValidationError,
-      message:
-        'This method is deprecated. MultiSig automatically is attached to the creators identity on creation.',
-    });
-
-    await expect(
-      prepareJoinCreator.call(proc, {
-        asPrimary: false,
-        multiSig,
-        permissions: {
-          assets: {
-            type: PermissionType.Include,
-            values: [entityMockUtils.getFungibleAssetInstance()],
-          },
-        },
-      })
-    ).rejects.toThrow(expectedError);
-  });
 });
 
 describe('getAuthorization', () => {
   let mockContext: Context;
 
   beforeEach(() => {
-    mockContext = dsMockUtils.getContextInstance();
+    mockContext = dsMockUtils.getContextInstance({ isV6: true });
   });
 
   it('should return the appropriate roles and permissions for as primary', () => {
@@ -256,4 +231,31 @@ describe('getAuthorization', () => {
       },
     });
   });
+
+  it('should throw an error if called from v7', () => {
+    mockContext = dsMockUtils.getContextInstance({ isV6: false });
+
+    const proc = procedureMockUtils.getInstance<Params, void>(mockContext);
+
+    const boundFunc = getAuthorization.bind(proc);
+
+    let expectedError = new PolymeshError({
+      code: ErrorCode.ValidationError,
+      message: 'This method is deprecated. Use `identities.rotatePrimaryKey` instead.',
+    });
+
+    expect(() =>
+      boundFunc({ asPrimary: true, multiSig: entityMockUtils.getMultiSigInstance() })
+    ).toThrow(expectedError);
+
+    expectedError = new PolymeshError({
+      code: ErrorCode.ValidationError,
+      message:
+        'This method is deprecated. MultiSig automatically is attached as secondary key to the creators identity.',
+    });
+
+    expect(() =>
+      boundFunc({ asPrimary: false, multiSig: entityMockUtils.getMultiSigInstance() })
+    ).toThrow(expectedError);
+  });
 });

src/api/procedures/joinCreator.ts

@@ -79,19 +79,11 @@ export async function prepareJoinCreator(
 > {
   const {
     context,
-    context: { polymeshApi, isV6 },
+    context: { polymeshApi },
   } = this;
   const { multiSig, asPrimary } = args;
   const tx = polymeshApi.tx as unknown as LocalSubmittableExtrinsics<ApiTypes>;
 
-  if (!isV6) {
-    throw new PolymeshError({
-      code: ErrorCode.NoDataChange,
-      message:
-        'This method is deprecated. MultiSig automatically is attached to the creators identity on creation.',
-    });
-  }
-
   const [signingIdentity, creator] = await Promise.all([
     context.getSigningIdentity(),
     multiSig.getCreator(),
@@ -162,6 +154,19 @@ export function getAuthorization(
   args: Params
 ): ProcedureAuthorization {
   const { asPrimary } = args;
+  const {
+    context: { isV6 },
+  } = this;
+
+  if (!isV6) {
+    throw new PolymeshError({
+      code: ErrorCode.NoDataChange,
+      message: asPrimary
+        ? 'This method is deprecated. Use `identities.rotatePrimaryKey` instead.'
+        : 'This method is deprecated. MultiSig automatically is attached as secondary key to the creators identity.',
+    });
+  }
+
   const transactions = [];
   if (asPrimary) {
     transactions.push(TxTags.multiSig.MakeMultisigPrimary);