destructor should keep already inert elements still inert

PolymerLabs · Aug 11, 2016 · 1a33482 · 1a33482
1 parent e4d46d5
commit 1a33482
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/blocking-elements.js b/blocking-elements.js
@@ -67,8 +67,8 @@
      */
     destructor() {
       // Pretend like top changed from current top to null in order to reset
-      // all its parents `inert`.
-      BlockingElements[_topChanged](null, this.top);
+      // all its parents inertness. Ensure we keep inert what was already inert!
+      BlockingElements[_topChanged](null, this[_topElement], this[_alreadyInertElements]);
       this[_topElement] = null;
       this[_blockingElements] = null;
       this[_alreadyInertElements] = null;
@@ -124,7 +124,7 @@
      */
     pop() {
       const top = this.top;
-      this.remove(top);
+      top && this.remove(top);
       return top;
     }