Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer paper-item creation to first open for enormous performance improvement #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aletorrado
Copy link

Hi, I've noticed a big performance penalty just by having about 20 paper-swatch-picker on a single page.

After research, it seems related to paper-item initialization, so I just deferred the paper-item creation to the first open event.

Previously there was a very similar strategy in place, probably for performance reasons as well, where the styling was applied on the first open event, so the change that was made is pretty simple.

@aletorrado aletorrado requested a review from keanulee as a code owner July 7, 2019 15:49
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 7, 2019
@aletorrado aletorrado changed the title Defer paper-init creation to first open for enormous performance improvement Defer paper-item creation to first open for enormous performance improvement Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants