This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Support LTR sliders in RTL pages #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankiefu
approved these changes
Jun 27, 2017
|
I'd like to know which Chrome milestone this fix will be included in. Is there an easy way for me to figure that out? Or, is it possible to have this merged into Chrome M61? |
|
@dschuyler might be able to answer that question ^ |
|
I did a quick look at the chromium code using code search and it doesn't look like this is present: |
|
Right, Chromium currently uses paper-slider v1.0.15 and this patch isn't included until v2.0.2. I was wondering if I can assume that Chrome M61 won't ship with v2.0.2 or later, since in that case I'll need to land a workaround similar to this in Chromium. |
|
I've updated the paper-slider used in Chromium to v2.0.2: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #190
This will setting a different direction with HTML attributes, like:
But not through CSS (which would require an expensive
getComputedStyle()for bootup).