Make ratio property 0-100 (consistent with iron-range-behavior) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankiefu
approved these changes
Jun 7, 2017
Closed
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Sep 2, 2017
paper-slider v2.0.2 has a breaking change. PolymerElements/paper-slider#194 |ratio| property used to return a value in [0, 1], but now it returns a value in [0, 100]. Making video player to catch up this change by dividing |ratio| property by 100. Bug: 752283 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iad994a2dd7f8a6e5b77698a0deec0812c70fb045 Reviewed-on: https://chromium-review.googlesource.com/646153 Reviewed-by: Yoshiki Iguchi <[email protected]> Commit-Queue: Naoki Fukino <[email protected]> Cr-Commit-Position: refs/heads/master@{#499126}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177
Before this patch, paper-slider’s
ratioproperty ranges 0-1.0 (https://github.com/PolymerElements/paper-slider/blob/master/paper-slider.html#L537). However, iron-range-behavior and paper-progress usesratiobetween 0-100 (https://github.com/PolymerElements/iron-range-behavior/blob/master/iron-range-behavior.html#L117). The timing changes with Polymer 2.0 surfaces this issue, since iron-range-behavior’s_updatemethod sets ratio between 0-100.This patch fixes this inconsistency by making paper-slider use the 0-100 range as well. However, it is technically a breaking change since the semantics of
ratiois now different. There are alternative fixes (e.g. override the_updatemethod in paper-slider), but that would mean this inconsistency would still exist, so I’m proposing this fix instead.