Fixes issue #159 #161
Closed
Fixes issue #159 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm experiencing the same issue in iOS/WkWebview. Waiting on this to be merged and new paper-drawer-panel release tagged. Thanks. |
|
Why is this not being merged, #159 is a really serious bug imho... |
|
@blasten Can you take a look on this? |
|
cc keanulee@ or ffu@
— Emmanuel
…On Thu, May 4, 2017 at 12:18 PM, TAS ***@***.***> wrote:
@blasten <https://github.com/blasten> Can you take a look on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABWGNVk-Rpk-sCCk_yITduQASX_rqLtEks5r2iSKgaJpZM4LW4_P>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #159.
Reproduce the issue:
The PR #158 changed the drawer opening and closing to be done inside a requestAnimationFrame. At the end of a swipe movement, the width is reset outside the rAF block, causing the opening/closing animation to be started from the initial position.
Solution:
Reset the drawer width inside the rAF Block that open or closes the drawer. It also restores the transition on the start and stop of edge peek.
Run the fix: https://jsfiddle.net/rdjxmax4/4/
@rubenstolk @blasten