-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced "sanitize" with "no-sanitize". #86
Conversation
…en when binding to the markdown-property or by embedding it as content.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it! |
CLAs look good, thanks! |
Heya, thanks for the PR, my reservations about this are:
Perhaps unsanitized is a better name. Since this is a breaking change I will have to run more-extensive internal integration tests to see the extent of the breakages and determine if it's fixable and does not break too many targets. |
@@ -142,9 +142,9 @@ | |||
value: null | |||
}, | |||
/** | |||
* Sanitize the output. Ignore any HTML that has been input. | |||
* Do not sanitize the output. Default ignores any HTML that has been input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better phrasing:
Disable sanitization. Default: Ignore any HTML tags contained within the input.
About the naming: I just wanted to mention that it's not uncommon that properties start with "no". I'm generally a big fan of the "safe by default" mentality. However, I do not think that it is wise to merge this. This will definitely break things. It'd be good if there was a deprecation warning to raise awareness first and to let |
I can confirm that this is causing significant breakages across Google. In terms of naming; I swear I saw this in one of our style guides but I can't seem to find it. |
Overall, due to the breaking changes, I'm going to have to close this PR. |
Made santize for all content the default and added a "no-sanitize" boolean property so you can disable this default.
It was mentioned in an Issues, but I decided to just go ahead and create the MR for it.
Fixes #40