Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Fix: Large iconsets rendering #79

Closed
stramel wants to merge 1 commit into from
Closed

Fix: Large iconsets rendering #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion iron-iconset-svg.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@
this._meta.key = this.name;
this._meta.value = this;

this.async(function() {
// Give time for icons to be added
Polymer.RenderStatus.afterNextRender(this, () => {
this.fire('iron-iconset-added', this, {node: window});
Copy link
Copy Markdown

@haydenmcp haydenmcp Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a 2.x legacy version? If so, maybe use this.dispatchEvent( ... );

Copy link
Copy Markdown
Author

@stramel stramel Jan 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polymer team's elements are hybrid and for the most part are using this.fire. I assume in the refactor of their elements they will switch to using this.dispatchEvent(new CustomEvent())

});
},
Expand Down