This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Delay firing iron-iconset-added until iconset fully parsed.#77
Open
andrey-git wants to merge 1 commit into
Open
Delay firing iron-iconset-added until iconset fully parsed.#77andrey-git wants to merge 1 commit into
andrey-git wants to merge 1 commit into
Conversation
Author
|
Fixes #66 |
8 tasks
|
This PR actually fixes a problem I have with loading icon sets on demand. I really hope that we can get this fixed or addressed somehow once Polymer 3 has shipped and the elements will get some love. On a side note, waiting for DOMContentLoaded before firing the event can be bad for performance. Imagine an iconset at the top of a page that is huge. Neat trick that I learned from AMP: it skips waiting for DOMContentLoaded if they know parsing is already done. They check this by seeing if element or any parent element has a sibling. If so, the children must have been done parsing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Chrome a custom element constructor and lifecycle callbacks are called as soon as the tag itself is parsed, i.e.
<iron-iconset-svg ... >but possibly before the child elements are parsed.This PR handles this case by waiting for
DOMContentLoadedbefore firingiron-iconset-addedif the document is in loading state