2.0-preview branch #64
Conversation
bicknellr
force-pushed
the
2.0-preview
branch
from
04d8624
to
aa84703
Compare
bicknellr
force-pushed
the
2.0-preview
branch
from
f562c05
to
1b769ec
Compare
2.0-preview updates to travis.yaml, bower.json, and more
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I'm deleting a bunch of @rjk40's comments: |
demo/index.html
Outdated
| } | ||
|
|
||
| .set:nth-of-type(4n) { | ||
| color: var( --google-blue-500); |
There was a problem hiding this comment.
nit: stray space before the --
| document.querySelector('[is=dom-bind]').getIconNames = function(iconset) { | ||
| return iconset.getIconNames(); | ||
| }; | ||
| window.addEventListener('WebComponentsReady', function() { |
There was a problem hiding this comment.
Why does the whole demo have to change?
There was a problem hiding this comment.
<iron-meta type="iconset" list="{{iconsets}}"></iron-meta>.. doesn't work anymore because list is no longer an observable property. Also, having the extra <dom-repeat> around the repeated items kind of screws up styling them since they're meant to flex and display: contents; doesn't actually work yet. The easiest way to handle this seemed to be to generate the DOM manually but I'm not attached to that method if you've got other recommendations. I tried changing it so that the <dom-repeat> elements were used for display instead of wrapping with divs but this seems to trigger a ShadyCSS problem that prevents all the styles on the page from being rewritten properly. I'll keep trying to revert this but the ShadyCSS thing is blocking it for now.
There was a problem hiding this comment.
tl;dr of @notwaldorf offline: 'wat, no'
There was a problem hiding this comment.
The list part makes sense and the var iconsets line makes sense. The constructing a 💩 ton of DOM seems silly and let's maybe not do that :)
| document.querySelector('[is=dom-bind]').getIconNames = function(iconset) { | ||
| return iconset.getIconNames(); | ||
| }; | ||
| window.addEventListener('WebComponentsReady', function() { |
There was a problem hiding this comment.
The list part makes sense and the var iconsets line makes sense. The constructing a 💩 ton of DOM seems silly and let's maybe not do that :)
Change Travis to Chrome beta
|
Still trying to figure out a minimal repro for this styling issue in the demo. |
|
Submitted as Polymer/polymer#4521. |
|
Polymer/polymer#4521 is fixed; I'll try reverting the demo changes again. |
|
Oh, there's not a release yet, the fix is still only available in master. |
|
Updating your local copy of Polymer to master makes the demo work but there's no release, so it won't work with just (edit: weird grammar) |
demo/index.html
Outdated
| return iconset.getIconNames(); | ||
| }; | ||
| window.addEventListener('WebComponentsReady', function() { | ||
| scope.getIconNames = |
There was a problem hiding this comment.
this trailing = is intentional, right? i might move the scope.parentNode line below to make that explicit, or indent it by 4. or something. right now it loos like a typo :)
There was a problem hiding this comment.
Yup, intentional. I changed this to two assignments.
|
@bicknellr one small nit left. gonna keep this red though until we can verify it works with the next rc release (hopefully tomorrow) |
|
@notwaldorf, 2.0.0-rc.4 is out with the custom-style fix. |
No description provided.