Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Reflect icon property to attribute #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reflect icon property to attribute #69

wants to merge 1 commit into from

Conversation

mgiuffrida
Copy link

It's nice to style iron-icons based on which icon they show:

iron-icon[icon='done'] {
  --iron-icon-fill-color: var(--google-green-500);
}

However, if the icon property is changed dynamically, the new style rules won't apply (even after updateStyles) because the attribute hasn't changed.

@mgiuffrida
Copy link
Author

/cc @azakus @kevinpschaaf

Would this have performance implications? iron-icon tends to be a high-frequency element, but the icon rarely changes, so it would mostly be an issue at startup.

@n1ywb n1ywb mentioned this pull request Jul 19, 2017
Open
@mgiuffrida
Reflect icon property to attribute
b6ce4d2 
It's nice to style `iron-icon`s based on which icon they show:

```
iron-icon[icon='done'] {
  --iron-icon-fill-color: var(--google-green-500);
}
```

However, if the `icon` property is changed dynamically, the new style rules won't apply (even after `updateStyles`) because the attribute hasn't changed.
@mgiuffrida
Copy link
Author

rebased

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stramel stramel stramel approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgiuffrida @stramel @googlebot