Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #183, add anchors for top-level exports. #184

Merged
merged 1 commit into from
May 8, 2018
Merged

Fix #183, add anchors for top-level exports. #184

merged 1 commit into from
May 8, 2018

Conversation

arthurevans
Copy link
Contributor

The scroll is off a little on these anchors for some reason. But they seem to work.
If there's a better fix, please close this PR!

@arthurevans arthurevans requested a review from rictic May 4, 2018 17:47
@arthurevans arthurevans requested a review from aomarks as a code owner May 4, 2018 17:47
rictic
rictic approved these changes May 4, 2018
View reviewed changes
Copy link
Contributor

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@arthurevans arthurevans mentioned this pull request May 4, 2018
Merged
@arthurevans
Copy link
Contributor Author

Thanks @rictic ... Two questions... Should I just merge this, or wait for approval from @aomarks?

And how do I go about getting this released? And should I bump the dependency version in the polymer docs repo?

Oops! That's three questions!

@arthurevans
Copy link
Contributor Author

Ping @rictic @aomarks ^^

@aomarks
Copy link
Contributor

aomarks commented May 7, 2018

And how do I go about getting this released? And should I bump the dependency version in the polymer docs repo?

Edit bower.json with the new version, and then use the github "draft new release" button .

@arthurevans arthurevans merged commit a62b00d into master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aomarks aomarks aomarks approved these changes

@rictic rictic rictic approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurevans @aomarks @rictic @googlebot