2.0-preview #122
2.0-preview #122
Conversation
test/index.html
Outdated
| 'iron-component-page.html', | ||
| 'iron-component-page.html?dom=shadow' | ||
| 'iron-component-page.html?dom=shadow', | ||
| 'iron-component-page.html?wc-shadowdom=true&wc-register=true' |
|
SHE SCROLLS! |
|
Something weird happened with the layout of the demo page in 2.x: it's crushed up below the header for some reason. Maybe the paper-header-panel to app-header-layout change needs a few extra touches? |
iron-component-page.html
Outdated
| <a view="[[_demoView(docDemos.0.path)]]"><iron-icon icon="visibility"></iron-icon> <span>Demo</span></a> | ||
| </iron-selector> | ||
| </paper-toolbar> | ||
| <app-header-layout> |
There was a problem hiding this comment.
has-scrolling-region or fullbleed attribute should be added to <app-header-layout>, otherwise the height of #content will be 0 and demos will not be visible.
|
@bicknellr, is #126 working for you? |
|
Yup, #126 works for me. |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Revert Travis Chrome beta to stable
DO NOT MERGE