Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New base property causes _srcChanged() to be invoked before this.src is set #17

Closed
jeffposnick opened this issue May 27, 2015 · 3 comments
Assignees

Comments

@jeffposnick
Copy link

4bc8531 introduced a race condition in which the new base property causes the _srcChanged() observer to be called before the src property is set.

Inside _srcChanged(), the check for this.src ends up being evaluated to false even if src is set on the element, since it hasn't been copied over to this yet.

This breaks doc pages when the src is meant to be something other than the parent directory's name with the .html suffix.

@atotic
Copy link
Contributor

atotic commented May 28, 2015

good one, working on it

@atotic atotic closed this as completed in aab5590 May 28, 2015
@jeffposnick
Copy link
Author

@atotic, the bug was re-added in 0f39606

Can you please cut a new release without using _srcObserver for base? Or find another way of achieving the same effect that doesn't have the same race condition?

This is preventing https://github.com/PolymerElements/platinum-sw from using the current release of <iron-component-page>. CC: @addyosmani @wibblymat

@atotic
Copy link
Contributor

atotic commented May 28, 2015

fixed again in 7e58148

@atotic atotic closed this as completed May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants