Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidentally merged #268 to #2.0-preview #276

Merged
merged 2 commits into from
May 24, 2017
Merged

Accidentally merged #268 to #2.0-preview #276

merged 2 commits into from
May 24, 2017

Conversation

e111077
Copy link
Contributor

@e111077 e111077 commented May 24, 2017

see #268

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@e111077 e111077 merged commit 4462f59 into master May 24, 2017
@e111077 e111077 added cla: yes and removed cla: no labels May 24, 2017
@stramel
Copy link
Contributor

stramel commented Jun 30, 2017

Should we just delete the 2.0-preview branch?

@e111077
Copy link
Contributor Author

e111077 commented Jun 30, 2017

Not just yet; we still don't want to break people relying on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants