Skip to content

Providers #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 24, 2017
Merged

Providers #20

merged 13 commits into from
Aug 24, 2017

Conversation

bennypowers
Copy link
Contributor

This PR adds a providers property, which users can use to define idP's in AWS credentials Logins map.

It also refactors the code which deals with credentials

@bennypowers
Copy link
Contributor Author

This isn't quite ready yet. I think adding a provider should toggle loggedIn

@bennypowers
Copy link
Contributor Author

Ok this is ready to fly at your discretion

*/
user: {
type: Object,
readOnly: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this still be readOnly for the outside world?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Computed properties are read only see Polymer/polymer#1925

@gjdenhertog gjdenhertog merged commit 08b0f04 into master Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants