Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "resolved" exclude path #817

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

rcashie
Copy link
Contributor

@rcashie rcashie commented Dec 15, 2018

Not sure if this was intentional or I'm just using it wrong but it seems as though paths / dirs specified via the excludes param must be absolute.

The following small change uses the resolved path so that relative paths work.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@rcashie
Copy link
Contributor Author

rcashie commented Dec 15, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@usergenic
Copy link
Contributor

Thanks, @rcashie - This looks great. Merging.

Copy link
Contributor

@usergenic usergenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usergenic usergenic merged commit 545bed1 into Polymer:master Jan 10, 2019
@usergenic
Copy link
Contributor

Turns out I just started resolving excludes on Bundler construction so this change is obviated by that change but you still win the merge commit. Thanks for submitting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants