Skip to content

Add bower_components to list of module directories#526

Merged
TimvdLippe merged 1 commit intoPolymer:masterfrom
LarsDenBakker:feature/resolve-bower-modules
Jun 26, 2018
Merged

Add bower_components to list of module directories#526
TimvdLippe merged 1 commit intoPolymer:masterfrom
LarsDenBakker:feature/resolve-bower-modules

Conversation

@LarsDenBakker
Copy link
Contributor

@LarsDenBakker LarsDenBakker commented Jun 16, 2018

The resolve module only resolves modules from the node_modules directory. Adding bower_components to it let's us use modules with bower, and matches the behavior of tools like Typescript.

Fixes #521

@daKmoR
Copy link

daKmoR commented Jun 25, 2018

anyone got time to review this?

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow bare specifier imports from bower_components

4 participants