Skip to content

Don't try to run Sauce from forked/community PRs. #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aomarks merged 1 commit into from
Jun 7, 2018
Merged

Don't try to run Sauce from forked/community PRs. #445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,8 @@ matrix:
sauce_connect: true
env:
- TEST_COMMAND="xvfb-run npm run test:integration"
- WCT_SAUCE=true
# We can't run Sauce without credentials. PRs from forks don't get secure
# environment variables. Only run Sauce if we have those vars. Note this
# means that community PRs never run on Sauce, even when the builds show
# all green.
- WCT_SAUCE=$TRAVIS_SECURE_ENV_VARS
2 changes: 1 addition & 1 deletion packages/esm-amd-loader/test/run-wct.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

if [ -n "$WCT_SAUCE" ]; then
if [ "$WCT_SAUCE" = "true" ]; then
npx wct --plugin local --plugin sauce
else
npx wct --plugin local
Expand Down
2 changes: 1 addition & 1 deletion packages/web-component-tester/test/integration/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function loadOptionsFile(dir: string): config.Config {

const testLocalBrowsers = !process.env.SKIP_LOCAL_BROWSERS;
const testLocalBrowsersList = parseList(process.env.TEST_LOCAL_BROWSERS);
const testRemoteBrowsers = process.env.WCT_SAUCE;
const testRemoteBrowsers = process.env.WCT_SAUCE === 'true';
if (testRemoteBrowsers &&
!(process.env.SAUCE_USERNAME && process.env.SAUCE_ACCESS_KEY)) {
throw new Error(
Expand Down