Conversation
Also replace SKIP_REMOTE_BROWSERS env var with WCT_SAUCE.
usergenic
reviewed
Jun 7, 2018
| "lint": "tslint --project . --format stylish", | ||
| "build": "npm run clean && tsc", | ||
| "test:wct": "npm run lint && npm run build && wct" | ||
| "test:wct": "npm run lint && npm run build && bash run-wct.sh" |
Contributor
There was a problem hiding this comment.
How does test:wct get invoked? Shouldn't this be test:integration?
Member
Author
There was a problem hiding this comment.
esm-amd-loader's test:integration command cds to this package and calls this script. i thought that made more sense, since it's the integration test for that package, which just happens to be implemented in a separate package.
usergenic
approved these changes
Jun 7, 2018
aomarks
added a commit
that referenced
this pull request
Jun 7, 2018
We can't because secure environment variables aren't available. This was already happening before #441 but in a slightly different way.
aomarks
added a commit
that referenced
this pull request
Jun 7, 2018
We can't because secure environment variables aren't available. This was already happening before #441 but in a slightly different way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also replace SKIP_REMOTE_BROWSERS env var with WCT_SAUCE.