Skip to content

[polyserve] bump mime to 2.x#417

Merged
TimvdLippe merged 1 commit intoPolymer:masterfrom
43081j:mime-update
Jun 27, 2018
Merged

[polyserve] bump mime to 2.x#417
TimvdLippe merged 1 commit intoPolymer:masterfrom
43081j:mime-update

Conversation

@43081j
Copy link
Copy Markdown
Contributor

@43081j 43081j commented May 29, 2018

Fixes #415.

Just bumped mime to its 2.x branch and fixed the single reference we have of it. Seems their 1 -> 2 breaking change was just API renaming.

WCT seemed to have the types too, but didn't have mime its self as a dep.. so i removed it. let me know if that was somehow a mistake.

If #395 gets merged first i will rebase and have npm sort the lock conflicts.

cc @justinfagnani

@43081j 43081j changed the title bump mime to 2.x [polyserve] bump mime to 2.x May 29, 2018
@web-padawan
Copy link
Copy Markdown
Contributor

web-padawan commented Jun 5, 2018

@43081j I was wondering if this is also expected to be handful for polymer analyze?
As of now, the .js bundle can be analysed but the exact same file with .mjs extension produces empty output, with no warnings etc.

/cc @rictic

Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me! Could you rebase on master and make sure the audit warnings remain resolved? Thanks!

@43081j
Copy link
Copy Markdown
Contributor Author

43081j commented Jun 26, 2018

@TimvdLippe i've rebased it to master.

the WCT package lock diff is pretty much unreviewable, shall we just assume it is fine? removing mime changed the lock a lot...

as for the audits, i can npm audit fix but that will add more version bumps we don't have in master.

@43081j
Copy link
Copy Markdown
Contributor Author

43081j commented Jun 26, 2018

we also get this now...

> web-component-tester@6.7.1 build /home/travis/build/Polymer/tools/packages/web-component-tester
> tsc && gulp build
runner/webserver.ts:222:9 - error TS2345: Argument of type '(app: Express, options: ServerOptions) => Promise<Express>' is not assignable to parameter of type 'ExpressAppMapper'.
  Type 'Promise<e.Express>' is not assignable to type 'Promise<e.Express>'. Two different types with this name exist, but they are unrelated.
    Type 'e.Express' is not assignable to type 'e.Express'. Two different types with this name exist, but they are unrelated.
      Property 'mountpath' is missing in type 'Express'.
222         appMapper);
            ~~~~~~~~~
runner/webserver.ts:249:13 - error TS2322: Type 'any' is not assignable to type 'never'.
249       const never: never = polyserveResult;
                ~~~~~

@TimvdLippe
Copy link
Copy Markdown
Contributor

Oh sorry, I meant the audit in polyserve. Wct I am working on in a different PR. Will take a look tomorrow.

@43081j
Copy link
Copy Markdown
Contributor Author

43081j commented Jun 26, 2018

ah polyserve reports 1 low vulnerability (deep-extend). same as master?

Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave WCT out for now, I will do that in a different PR. Thus, this PR should just update the package in polyserve. The remaining audit failure is in the bundler, which is already fixed, just not released.

@43081j
Copy link
Copy Markdown
Contributor Author

43081j commented Jun 27, 2018

@TimvdLippe i dropped the changes to wct now

Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@TimvdLippe TimvdLippe merged commit f46ef67 into Polymer:master Jun 27, 2018
@43081j 43081j deleted the mime-update branch June 27, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[polyserve] Update mime dependency

4 participants