[polyserve] bump mime to 2.x#417
Conversation
TimvdLippe
left a comment
There was a problem hiding this comment.
This seems good to me! Could you rebase on master and make sure the audit warnings remain resolved? Thanks!
|
@TimvdLippe i've rebased it to master. the WCT package lock diff is pretty much unreviewable, shall we just assume it is fine? removing mime changed the lock a lot... as for the audits, i can |
|
we also get this now... |
|
Oh sorry, I meant the audit in polyserve. Wct I am working on in a different PR. Will take a look tomorrow. |
|
ah polyserve reports 1 low vulnerability (deep-extend). same as master? |
TimvdLippe
left a comment
There was a problem hiding this comment.
Let's leave WCT out for now, I will do that in a different PR. Thus, this PR should just update the package in polyserve. The remaining audit failure is in the bundler, which is already fixed, just not released.
|
@TimvdLippe i dropped the changes to wct now |
Fixes #415.
Just bumped mime to its 2.x branch and fixed the single reference we have of it. Seems their 1 -> 2 breaking change was just API renaming.
WCT seemed to have the types too, but didn't have
mimeits self as a dep.. so i removed it. let me know if that was somehow a mistake.If #395 gets merged first i will rebase and have npm sort the lock conflicts.
cc @justinfagnani