Conversation
Contributor
Author
|
@rictic I added a build to the polymer.json for the modules fixture which demonstrates the particular case addressed by this PR's updates to the html-bundler.ts - I may add more module bundling cases next week in a different PR. |
…nal module script tags.
…n't want them, thanks vscode.
usergenic
force-pushed
the
es6-module-inlining-fail
branch
from
34c39a8 to
3a482dd
Compare
Contributor
Author
|
Just rebased on master for clarity. |
rictic
approved these changes
May 7, 2018
…wasn't actually inlining anything when previously that was what its name implied. _inlineModuleScripts -> _rewriteExternalModuleScriptTagsToImports
…te the goldens which are now happy goldens.
justinfagnani
pushed a commit
that referenced
this pull request
Jul 10, 2018
Fixes #334 Also: - Added `--flat` and `--private` CLI flags, both of which default to `false`. Previously we set `flat` to `true` by default, and did not touch `private`. - Map Bower `main` foo.html to NPM `main` foo.js. Previously we just copied it. - Check for multiple licenses (valid for Bower, not for NPM) and warn. - Add typings for NPM and Bower configs. - Map Bower `authors` to NPM `author`/`contributors`. Previously we directly copied `authors`, which doesn't exist in Bower (although we use it in at least one element, so I kept it as a fallback). - Improve warning messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #332 which was due to a misunderstanding of what
_inlineModuleScriptswas doing (it wasn't inlining module scripts, it was rolling up scripts that were already inline) and so external script type module tags were being ruined by having their attributes set to relative path to the bundle, which is an empty string.This is fixed.
Inlining strategy is basically creating a script tag with a single import statement to the thing to import and letting existing rollup code take care of the rest.