Merged
Conversation
aomarks
force-pushed
the
wct-windows-path
branch
4 times, most recently
from
86262af to
1fad31e
Compare
Also rename some test fixture files so that new implementation can really find the files it is resolving.
rictic
approved these changes
May 5, 2018
| {basedir: wctPackageRoot}); | ||
| const relativeFilepath = path.relative(rootNodeModules, absoluteFilepath); | ||
| // Convert Windows filesystem paths. | ||
| const relativeUrl = relativeFilepath.replace(/\\/g, '/'); |
Contributor
There was a problem hiding this comment.
We should do this only on Windows
|
Excuse my naivety and please shout if there's a central place to check this stuff but does anyone know when this will be released? |
Member
Author
|
Today! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix node package file resolution under Windows. We were not accounting for Windows style paths. Also simplify the implementation a bit, and rename some test fixture files so that new implementation can really find the files it is resolving.
Fixes https://github.com/Polymer/web-component-tester/issues/694