Conversation
rictic
approved these changes
May 4, 2018
Contributor
rictic
left a comment
rictic
left a comment
There was a problem hiding this comment.
How are these targets specified? We should be more specific I think
Member
Author
Clarified, and also added the entry to polymer-project-config. |
justinfagnani
pushed a commit
that referenced
this pull request
Jul 10, 2018
* Fix: Remove top-level use-strict statement * Move to separate pass * Update project-converter_test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were forgotten earlier, but are pretty important.