Conversation
rictic
reviewed
May 3, 2018
Contributor
rictic
left a comment
rictic
left a comment
There was a problem hiding this comment.
Nice cleanup, one question
packages/analyzer/package.json
Outdated
| "homepage": "https://github.com/Polymer/polymer-analyzer", | ||
| "bugs": "https://github.com/Polymer/polymer-analyzer/issues", | ||
| "homepage": "https://github.com/Polymer/tools/tree/master/packages/analyzer", | ||
| "repository": "https://github.com/Polymer/tools/tree/master/packages/analyzer", |
Contributor
There was a problem hiding this comment.
Should the repo be a clonable URL?
Member
Author
There was a problem hiding this comment.
Maybe, I was copying how Babel did it for their monorepo: https://github.com/babel/babel/blob/master/packages/babel-cli/package.json
But reading https://docs.npmjs.com/files/package.json#repository maybe it should be the top-level repo. Although I don't actually know of any real world use case for this field, it sounds kind of hypothetical here.
Member
Author
There was a problem hiding this comment.
Updated all of them to github:Polymer/tools
usergenic
approved these changes
May 3, 2018
Contributor
usergenic
left a comment
usergenic
left a comment
There was a problem hiding this comment.
This is friendly. LGTM
rictic
approved these changes
May 3, 2018
justinfagnani
approved these changes
May 3, 2018
justinfagnani
pushed a commit
that referenced
this pull request
Jul 10, 2018
* update analyzer to v3.0.0-pre.10, typescript * fix undefined check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.