Conversation
rictic
approved these changes
Apr 25, 2018
Contributor
|
Looks like appveyor is running with node 10 and no longer failing where it was before. Now we've just got a minor whitespace difference in the polymer build integration test goldens. Mind fixing that too in this PR? |
Contributor
|
Hm, weirdly though, node 6 passes on travis without whitespace changes… |
Contributor
Author
|
Side note: I believe Node 10 has issues (even locally) in polymer-build tests with some dependency of the |
…ert' standard lib.
7c05376 to
fb5ce8d
Compare
This was referenced Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As of node 10,
console.assert()doesn't throw an AssertionError anymore. Howeverconst assert = require('assert'); assert();does. So I switched over toassert()whereverconsole.assert()was in use.