[analyzer] support all default param types#160
Merged
rictic merged 4 commits intoPolymer:masterfrom Apr 18, 2018
Merged
Conversation
TimvdLippe
approved these changes
Apr 17, 2018
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Deleting code AND fix issues. FeelsGoodMan! I wanted to take a stab, but this solution is the best 😄
Contributor
|
|
Contributor
|
Pushed up a merge commit, if it passes I'll merge this in |
Contributor
Author
|
thanks for that, had gone mobile yesterday 🙊 the tests failed because of an ordering mistake in the assertions by the looks of it. will fix it shortly |
Contributor
|
LGTM! |
This was referenced Sep 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #132.
We were only accepting literal right hand values before, but really i suppose we don't care what it is. it gets turned into a string anyway.