Skip to content

Commit

Permalink
Remove hardcoded Sauce Connect version (#33)
Browse files Browse the repository at this point in the history
* Remove manual Sauce Connect version override

sauce-connect-launcher now fetches the "latest" version, which should be
just fine.

* add changelog bit
  • Loading branch information
dfreedm authored and usergenic committed Jun 8, 2018
1 parent 7ba139f commit fb2831b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
2 changes: 2 additions & 0 deletions packages/wct-sauce/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Remove hardcoded Sauce Connect version

## 2.0.0-pre.4 - 2018-01-09

- Removed the Linux Chrome 'dev' version browser, which is not a thing that Sauce does.
Expand Down
11 changes: 1 addition & 10 deletions packages/wct-sauce/lib/sauce.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ function startTunnel(config, emitter, done) {
emitter.emit('log:info', 'Creating Sauce Connect tunnel');
emitter.emit('log:info', 'Sauce Connect log:', chalk.magenta(logPath));

setSauceConnectDownloadVersion();

sauceConnect(connectOptions, function(error, tunnel) {
if (error) {
emitter.emit('log:error', 'Sauce tunnel failed:');
Expand Down Expand Up @@ -87,14 +85,7 @@ function isTravisSauceConnectRunning() {
}
}

// sauce-connect-launcher only checks the environment variable
// $SAUCE_CONNECT_VERSION
function setSauceConnectDownloadVersion() {
process.env.SAUCE_CONNECT_VERSION = '4.4.0';
}

module.exports = {
startTunnel: startTunnel,
isTravisSauceConnectRunning: isTravisSauceConnectRunning,
setSauceConnectDownloadVersion: setSauceConnectDownloadVersion
isTravisSauceConnectRunning: isTravisSauceConnectRunning
};
2 changes: 0 additions & 2 deletions packages/wct-sauce/scripts/postinstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ var sauce = require('../lib/sauce');
if (!(sauce.isTravisSauceConnectRunning() || process.env.SKIP_WCT_SAUCE_POSTINSTALL_DOWNLOAD)) {
console.log('Prefetching the Sauce Connect binary.');

sauce.setSauceConnectDownloadVersion();

requireSauceConnectLauncher(function(sauceConnectLauncher) {
sauceConnectLauncher.download({
logger: console.log.bind(console),
Expand Down

0 comments on commit fb2831b

Please sign in to comment.