Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #29 #32

Merged
merged 1 commit into from
May 24, 2016
Merged

Fix #29 #32

merged 1 commit into from
May 24, 2016

Conversation

blasten
Copy link
Contributor

@blasten blasten commented May 24, 2016

No description provided.

@frankiefu
Copy link
Member

LGTM

@frankiefu frankiefu merged commit efae7ae into master May 24, 2016
@frankiefu frankiefu deleted the title branch May 24, 2016 21:35
@abdonrd
Copy link

abdonrd commented Jun 1, 2016

@blasten @frankiefu Did you deploy it? I always have the same title if I share shop links in social networks.

@frankiefu
Copy link
Member

Not yet, but we will push a new build sometimes this week. Thanks.

@blasten
Copy link
Contributor Author

blasten commented Jun 1, 2016

I don't think that it will fix the issue when sharing a link though. Facebook and Twitter bots only look for static meta elements in the markup. e.g. https://developers.facebook.com/docs/sharing/webmasters

@abdonrd
Copy link

abdonrd commented Jun 1, 2016

@frankiefu thanks!

@blasten but if you don't have the meta og, they get the title.
I already report at new docs site too: Polymer/old-docs-site#1632

I think that is a very very important thing.

@blasten
Copy link
Contributor Author

blasten commented Jun 1, 2016

@abdonrd but it has to be static I think. I don't think they run a browser in the server to extract the meta data.

@abdonrd
Copy link

abdonrd commented Jun 1, 2016

@blasten probably you are right. 😕

Do you plan any solution?

@blasten
Copy link
Contributor Author

blasten commented Jun 2, 2016

@abdonrd the solution would require server-side support, potentially the server could detect the user agent and if it's facebot, for example, then it can inject the <meta> elements. Unfortunately, this is a little bit out of scope for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants