Allow undefined in legacy _template field to fall-through to normal lookup path
#5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorvell
reviewed
Jan 22, 2020
sorvell
approved these changes
Jan 22, 2020
added 2 commits
January 21, 2020 17:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
undefinedin legacy _template field to fall-through to normal lookup path.Allows a user to unconditionally set
_templateto a value and have build-time controls to change the value between a template andundefinedto allow build-time experimentation with transitioning from<dom-module>templates to inlined templates in JS.