Skip to content

FIx closure annotation #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

FIx closure annotation #5614

merged 1 commit into from
Jan 13, 2020

Conversation

sorvell
Copy link
Contributor

@sorvell sorvell commented Jan 13, 2020

Closure was unhappy with the change from var to let so reverting it.

FIx closure annotation
15ce881 
Closure was unhappy with the change from `var` to `let` so reverting it.
@sorvell sorvell requested a review from dfreedm January 13, 2020 19:25
@sorvell sorvell requested a review from kevinpschaaf as a code owner January 13, 2020 19:25
@sorvell sorvell merged commit 13a8ea4 into master Jan 13, 2020
@sorvell sorvell deleted the closure-extern-fix branch January 13, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rictic rictic rictic approved these changes

@dfreedm dfreedm dfreedm approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorvell @rictic @dfreedm @googlebot